Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#5880 closed change (fixed)

Create a minimal issue reporter

Reported by: fhd Assignee: trev
Priority: P1 Milestone: Adblock-Plus-3.0-for-Firefox
Module: User-Interface Keywords:
Cc: greiner, wspee, nicole Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29583568/

Description (last modified by fhd)

Background

We're about to move ABP for Firefox to the new WebExtensions code base, which means we will lose our old issue reporter, which means filter list authors will not get issue reports anymore. That's bad, so we want to include at least a minimal issue reporter in the initial release.

What to change

Create an issue reporter that sends at least the following fields:

  • subscriptions
  • type
  • comment
  • main_url

Anything else is optional.

Design and copy is not specified. It's OK if this is not translated at first.

Change History (8)

comment:1 Changed 6 months ago by fhd

  • Description modified (diff)

comment:2 Changed 6 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 months ago by abpbot

A commit referencing this issue has landed:
Issue 5880 - Basic issue reporter implementation

comment:4 Changed 6 months ago by abpbot

A commit referencing this issue has landed:
Issue 5880 - Added strings used by issue reporter as well

comment:5 Changed 6 months ago by abpbot

comment:6 Changed 6 months ago by trev

  • Blocking 5883 added

comment:7 Changed 6 months ago by trev

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

I'll create follow-up issues and link them to #5883.

comment:8 Changed 6 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Appears to work okay in most recent browser versions.

Fails in older browser versions (covered by #5967).

ABP 1.13.4.1903
Chrome 49 / 62 / Windows 10
Opera 36 / 48 / Windows 10

ABP 2.99.0.1902beta
Firefox 50 / 57 / Windows 10

Note: See TracTickets for help on using tickets.