#5896 closed change (fixed)

Simplify error handling in the issue reporter

Reported by: trev Assignee: trev
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner Blocked By:
Blocking: #5883 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29587629/

Description

Background

When #5880 was implemented, we had to expect the case where a promise would be rejected with a plain object. This has been addressed in an additional commit in #4579 now so that rejection reason is always an Error instance.

What to change

Drop the unnecessary if (!e.name && e.message) block in issue reporter's initDataCollector() function.

Change History (4)

comment:1 Changed 22 months ago by trev

  • Owner set to trev

comment:2 Changed 22 months ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 22 months ago by abpbot

A commit referencing this issue has landed:
Issue 5896 - Simplify error handling in the issue reporter

comment:4 Changed 22 months ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.