Opened 3 years ago

Closed 2 years ago

#5900 closed change (duplicate)

Handle binary attributes in separate function

Reported by: saroyanm Assignee:
Priority: P4 Milestone:
Module: User-Interface Keywords: options-page
Cc: greiner Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by saroyanm)


Currently codebase of the options page check if binary attributes set using element.getAttribute (ex.: element.getAttribute("aria-checked") == "true") this happens because we do not remove attribute if needed, but rather set the value to false. In order to be able to check binary attributes element.hasAttribute we should remove the attribute rather than set to false.

What to change

Implement an utility method that will remove the binary attribute instead of setting it to false

Change History (3)

comment:1 Changed 3 years ago by greiner

  • Cc greiner added

comment:2 Changed 3 years ago by saroyanm

  • Description modified (diff)

comment:3 Changed 2 years ago by greiner

  • Resolution set to duplicate
  • Status changed from new to closed

This has been added as part of #6514 (see js/io-element.js) so I'm closing this ticket as duplicate.

Note: See TracTickets for help on using tickets.