Opened 2 years ago

Closed 20 months ago

#5907 closed change (fixed)

Fix new abp.org navbar on scroll up

Reported by: juliandoucette Assignee: Yael
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: ire, wpsee, jeen, Yael Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://github.com/adblockplus/web.adblockplus.org/pull/7

Description (last modified by juliandoucette)

Background

See spec.

What to change

Fix the navbar top when scrolled down the page and scrolling upwards.

Change History (14)

comment:1 follow-up: Changed 2 years ago by juliandoucette

  • CC Ire because this feature may be desirable in website-defaults and help-centre
  • P4 because this may not get done before adblockplus.org 2.0.0 completes

comment:2 in reply to: ↑ 1 Changed 2 years ago by ire

Replying to juliandoucette:

  • CC Ire because this feature may be desirable in website-defaults and help-centre

+1

Ack.

comment:3 follow-up: Changed 2 years ago by juliandoucette

@ire do you think we should block this with #5635?

comment:4 in reply to: ↑ 3 Changed 2 years ago by ire

Replying to juliandoucette:

@ire do you think we should block this with #5635?

Yes I think that makes sense.

We should probably create a separate issue to add this functionality to website-defaults as well since #5635 isn't providing support for it.

comment:5 Changed 2 years ago by juliandoucette

  • Cc wpsee jeen added
  • Description modified (diff)
  • Priority changed from P4 to P3

@Jeen I think that this functionality is less important than the content updates. Do you agree?

comment:6 Changed 2 years ago by juliandoucette

  • Ready set

comment:7 Changed 22 months ago by juliandoucette

  • Milestone adblockplus.org 2.0.0 deleted

Milestone adblockplus.org 2.0.0 deleted

comment:8 Changed 21 months ago by juliandoucette

(Jeen agreed)

comment:9 Changed 21 months ago by juliandoucette

  • Cc Yael added

comment:10 Changed 21 months ago by juliandoucette

  • Owner set to Yael
  • Review URL(s) modified (diff)

comment:11 Changed 21 months ago by juliandoucette

  • Status changed from new to reviewing

comment:12 Changed 21 months ago by abpbot

A commit referencing this issue has landed:
Issue 5907 - Made navbar fixed and hide/show on scroll

comment:14 Changed 20 months ago by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.