Opened 20 months ago

Closed 20 months ago

Last modified 20 months ago

#5913 closed defect (fixed)

ensure_dependencies.py doesn't install Node.js dependencies on Windows

Reported by: kzar Assignee: tlucas
Priority: Unknown Milestone:
Module: Automation Keywords:
Cc: oleksandr, sebastian, tlucas, trev Blocked By:
Blocking: #5915, #5916, #5922 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29587652/

Description

Environment

Windows 10, with creators update.
ActivePython 2.7.13
Node.js 6.11.4
Git 2.14.3

How to reproduce

  1. Click Node.js command prompt from the start menu.
  2. Type these commands:
git clone https://github.com/adblockplus/adblockpluschrome.git
cd adblockpluschrome
python build.py -t edge devenv

Observed behaviour

The dependencies are cloned, but the "Failed to install Node.js dependencies for buildtools please ensure Node.js is installed.' message is displayed.

Expected behaviour

Node.js dependencies are installed successfully.

Notes

Installing the dependencies manually works fine:

cd buildtools
npm install

Change History (10)

comment:1 Changed 20 months ago by kzar

  • Blocking 5915 added

comment:2 Changed 20 months ago by kzar

  • Blocking 5916 added

comment:3 Changed 20 months ago by tlucas

  • Owner set to tlucas

comment:4 Changed 20 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 20 months ago by tlucas

  • Blocking 5921 added

comment:6 Changed 20 months ago by tlucas

  • Blocking 5922 added

comment:7 Changed 20 months ago by abpbot

A commit referencing this issue has landed:
Issue 5913 - call correct npm executable on Win

comment:8 Changed 20 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 20 months ago by tlucas

  • Blocking 5921 removed

comment:10 Changed 20 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Create build in Windows 10 with above steps.

adblockpluschrome / be662daa41af0c5e27ffb7ce2711d16dc0e1903a

Note: See TracTickets for help on using tickets.