Opened 2 years ago

Closed 20 months ago

#5921 closed change (invalid)

Update buildtools dependency in adblockplusui to resolve a npm related regression

Reported by: tlucas Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: kzar, sebastian, oleksandr, greiner, saroyanm Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by tlucas)

Background

The list of changes for buildtools imported by this is:

Ticket Summary Component
#5939 Crowdin downloads suffixed translations to the wrong folder Automation
#5916 Locale strings are broken in adblockpluschrome when building from Windows Automation
#5915 adblockpluschrome won't build under Windows Automation
#5913 ensure_dependencies.py doesn't install Node.js dependencies on Windows Automation
#5895 Let npm not try to resolve optional dependencies Automation
#5877 First run page is missing some text Automation
#5857 ensure_dependencies.py does not resolve Node.js dependencies if a previous installation failed Automation
#5856 Remove the package-lock.json file from buildtools Automation
#5535 Begin using webpack for script bundling in the Chrome packager Automation
#5383 Add tests for the Chrome and Firefox packagers Automation
#5028 Use the browser extension API via the "browser" (instead of "chrome") namespace Platform
#4720 Edge packager does not support devenv Automation


4d26be1c438eNoissue - Use sets in build.py were appropriateTristan Lucas

The relevant changes are #5939 (in order to properly synchronize translations), #5895 (preventing undesired output on automation servers), #5857 (resolves npm dependencies if they previously failed) and #5856 (prevents the creation of a npm-version dependent package-lock.json).

What to change

  • Change the buildtools dependency to match the respective revision, after #5913 has landed.
hg git
39a589de5c18 0373bbf
  • Make sure to include the newer version of ensure_dependencies.py

Hints for testers

When trying to build a package in adblockpluschrome, you might have to clean up buidtools in adblockplusui (e.g. delete the folders) - further information can be found in #5856.

Change History (6)

comment:1 Changed 2 years ago by tlucas

  • Blocking 5922 added

comment:2 Changed 2 years ago by kzar

  • Blocking 5922 removed

comment:3 Changed 2 years ago by tlucas

  • Blocked By 5913 removed
  • Cc trev added
  • Description modified (diff)

comment:4 Changed 2 years ago by tlucas

  • Description modified (diff)

comment:5 Changed 2 years ago by fhd

  • Cc trev removed

comment:6 Changed 20 months ago by tlucas

  • Resolution set to invalid
  • Status changed from new to closed

The mentioned updates are already included.

Note: See TracTickets for help on using tickets.