Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5925 closed change (fixed)

Update the adblockplusui dependency to 0cc24b2b5ded

Reported by: saroyanm Assignee:
Priority: P2 Milestone: Adblock-Plus-3.0-for-Firefox
Module: Platform Keywords:
Cc: fhd, wspee, greiner, Shikitita, kzar, sebastian, trev Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29587623/

Description (last modified by kzar)

Background

With #5158 we implemented the new options page. Since then we've implemented some further important changes which the adblockplusui team would like to make it into the upcoming Firefox web extensions release:

  • Using check-boxes for controlling Acceptable Ads (#5632).
  • Updated strings that match strings we have received from the translation agencies (#5874)

Additional changes relating to the issue reporter (#5883) will also be included, along with updated translations and a fix for some warnings in the new options page #5926.

What to change

  • Update the adblockplusui dependency to hg:0cc24b2b5ded git:915236b. The changes included all relate to the new options page, the issue reporter and related strings.
  • Update metadata.chrome so skin/fonts/SourceSansPro-*.woff from the adblockplusui repository are included in the build.
  • Update metadata.chrome so skin/abp-logo.svg from the adblockplusui repository is included in the build.

Note

  • I don't know if there is fixed release date already, but the hard deadline for releasing used to be before November.
  • Tamara is planing to update the translations in the crowdin after the String changes in #5874 are pushed.

Hints for testers

  • Check that the strings are on the old options page haven't been broken.
  • Test the new options page, especially toggling acceptable ads toggling interface.
  • Test the issue reporter (click the ABP icon, then "Report issue on this page".)

Change History (10)

comment:1 Changed 2 years ago by saroyanm

  • Cc kzar sebastian added

comment:2 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:3 Changed 2 years ago by saroyanm

  • Cc trev added
  • Description modified (diff)

comment:4 Changed 2 years ago by kzar

  • Component changed from Adblock-Plus-for-Firefox to Platform
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set
  • Summary changed from Dependancy update for strings and checkboxes for Acceptable Ads control to Update the adblockplusui dependency to a65aba31839f

Thanks for filing the issue Manvel, I've updated it somewhat. Most significantly I changed the revisions for the update to include Wladimir's recent issue reporter improvements.

I agree with what you said in IRC, let's wait until tomorrow to land this change since we need to check about what the plan is with the release first. I don't want to mess that up for everyone if we're in a string freeze.

comment:5 Changed 2 years ago by kzar

  • Summary changed from Update the adblockplusui dependency to a65aba31839f to Update the adblockplusui dependency to e7371d9c682d

comment:6 Changed 2 years ago by kzar

  • Description modified (diff)

comment:7 Changed 2 years ago by kzar

  • Description modified (diff)
  • Summary changed from Update the adblockplusui dependency to e7371d9c682d to Update the adblockplusui dependency to 0cc24b2b5ded

comment:9 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

comment:10 Changed 2 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
Note: See TracTickets for help on using tickets.