Opened 2 years ago

Closed 2 years ago

#5926 closed defect (fixed)

Missing string errors in the new settings page

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords: options-page
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29587717/

Description (last modified by saroyanm)

Environment

ABP 2.99.0.1889beta Devbuilds
Firefox 56

How to reproduce

  1. Open the option page
  2. Open the developer toolbar from the about:debugging#addons
  3. Observe

Observed behaviour

Errors regarding missing strings in the options page are thrown:

Unknown localization message options_language_en  desktop-options.js:514
Unknown localization message options_language_id  desktop-options.js:514
Unknown localization message options_language_vi  desktop-options.js:514
Unknown localization message options_language_bg  desktop-options.js:514
Unknown localization message options_language_zh  desktop-options.js:514
Unknown localization message options_language_cs_sk  desktop-options.js:514
Unknown localization message options_language_nl  desktop-options.js:514
Unknown localization message options_language_de  desktop-options.js:514
Unknown localization message options_language_he  desktop-options.js:514
Unknown localization message options_language_it  desktop-options.js:514
Unknown localization message options_language_lt  desktop-options.js:514
Unknown localization message options_language_es  desktop-options.js:514
Unknown localization message options_language_lv  desktop-options.js:514
Unknown localization message options_language_ar  desktop-options.js:514
Unknown localization message options_language_fr  desktop-options.js:514
Unknown localization message options_language_ro  desktop-options.js:514
Unknown localization message options_language_ru_uk

Expected behaviour

No error regarding missing strings

Change History (5)

comment:1 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:2 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 years ago by saroyanm

  • Description modified (diff)

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5926 - fix missing languages string errors

comment:5 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.