Opened on 10/25/2017 at 07:16:08 AM

Closed on 11/02/2017 at 10:10:05 AM

Last modified on 12/22/2017 at 12:31:32 PM

#5929 closed change (fixed)

Skip update subscription URLs in AndroidWebRequest if not required

Reported by: asmirnov Assignee:
Priority: Unknown Milestone:
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



In order to save memory AndroidWebRequest ( filters out not required filters from subscriptions. For example if element hiding is disabled (enableElemhide =falsein ctor it leaves lines from not listed subscriptions ( and removes lines with elemhide rules.

If element hiding is enabled (enableElemhide =truein ctor, this.elemhideEnabled ( is set to true and we need no listed subscription URLs at all as condition is always true. So there will be no isListedSubscriptionUrl() invocations and we don't need subscription URLs list at all.

Thus we can skip calling androidWebRequest.updateSubscriptionURLs(engine.filterEngine); in if element hiding is enabled (by default it is enabled and improve start-up time.

It's good because it happens in UI thread and UI is frozen for the user, so we can make UI more responsive with no cost at all (just skip doing what is not required).

What to change

Skip calling androidwebRequest.updateSubscriptionURLs() if element hiding is enabled.

Attachments (0)

Change History (4)

comment:1 Changed on 10/25/2017 at 08:22:08 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 11/02/2017 at 10:09:32 AM by abpbot

comment:3 Changed on 11/02/2017 at 10:10:05 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed on 12/22/2017 at 12:31:32 PM by abpbot

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Note: See TracTickets for help on using tickets.