Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5930 closed change (fixed)

Turn off "MissingTranslation" lint warnings

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By: #5902
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29588559/

Description

Background

In task #5902 we've added translations for settings UI. However while building WebViewApp (https://github.com/adblockplus/libadblockplus-android/tree/master/libadblockplus-android-webviewapp) we can get warnings/errors as some strings are not translated. Actually it was done intentionally as some strings are internal and should not be translated (eg. https://github.com/adblockplus/libadblockplus-android/blob/master/libadblockplus-android-settings/res/values/adblock_settings_strings_internal.xml). Also some strings in WebView app are not required to be translated as it's just an example of library usage so it does not affect any 3rd-party app using libadblockplus-android.

What to change

Disable "MissingTranslation" warning/error for the files that should not be translated.

Change History (4)

comment:1 Changed 2 years ago by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5930 - Turn off "MissingTranslation" lint warnings

comment:3 Changed 2 years ago by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:4 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5930 - Turn off "MissingTranslation" lint warnings

Note: See TracTickets for help on using tickets.