Opened 2 years ago

Last modified 14 months ago

#5938 closed defect

webextension: "block element" does not appear in menu for FB — at Version 7

Reported by: mapx Assignee:
Priority: P2 Milestone: Adblock-Plus-3.5-for-Chrome-Opera-Firefox
Module: Platform Keywords: externaldependencies
Cc: mjethani, kzar, sebastian, hfiguiere, Ross, cjsmall, greiner Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29589668/
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/22

Description (last modified by kzar)

Environment

FF 57
ABP 2.99.0.1896
easylist / easyprivacy

How to reproduce

go to facebook
click ABP icon

Observed behaviour

"block element" entry missing

Expected behaviour

"block element" entry available

Notes

  • An error shows up in the background console when the popup is opened, but only when the problem is happening:
Unchecked lastError value: Error: ext is not defined  ExtensionCommon.jsm:304
	withLastError resource://gre/modules/ExtensionCommon.jsm:304:9
	wrapPromise/< resource://gre/modules/ExtensionCommon.jsm:357:11
  • This does not seem to be a recent regression, I tested quite far back and could consistently reproduce the problem.
  • I can still reproduce the problem with EasyList disabled, which I found surprising.
  • I can't reproduce the problem on other sites, for example https://reddit.com

Change History (7)

comment:1 Changed 2 years ago by mapx

  • Component changed from Unknown to Platform

comment:2 Changed 2 years ago by mapx

  • Description modified (diff)

comment:3 Changed 2 years ago by kzar

  • Cc hfiguiere Ross added
  • Platform changed from Unknown / Cross platform to Firefox

comment:4 Changed 2 years ago by kzar

  • Priority changed from Unknown to P2
  • Ready set

I can reproduce this as described, investigating.

comment:5 Changed 2 years ago by kzar

  • Description modified (diff)

comment:6 Changed 2 years ago by mapx

Could be related to this ticket ?
https://issues.adblockplus.org/ticket/5817

Does FB use some restrictive CSP directives ?

comment:7 Changed 2 years ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.