Opened 6 years ago

Closed 6 years ago

#594 closed defect (fixed)

Typo in preferences window tooltip for the slow filters column

Reported by: Gingerbread Man Assignee:
Priority: Unknown Milestone: Adblock-Plus-2.6.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: trev, philll Blocked By:
Blocking: Platform:
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

http://codereview.adblockplus.org/6363941206753280

Description

Environment

Adblock Plus 2.6.1.3824 • Nightly 32.0a1 (2014-06-01)

How to reproduce

  1. Open the preferences window.
  2. If filters aren't displayed on the right, press Ctrl+R to show them.
  3. Place the mouse cursor over the ! for the slow filters column.

Observed behavior

The tooltip says, "Slo&w filters".

Expected behaviour

The tooltip should say, "Slow filters".

Forum thread

https://adblockplus.org/forum/viewtopic.php?f=11&t=23378

Attachments (1)

slow_filters_tooltip.png (5.4 KB) - added by Gingerbread Man 6 years ago.
slow_filters_tooltip.png

Download all attachments as: .zip

Change History (5)

Changed 6 years ago by Gingerbread Man

slow_filters_tooltip.png

comment:1 Changed 6 years ago by philll

  • Cc trev philll added

@trev: this file contains a lot of translations with ampersands where I wouldn't expect them, being created by you. I guess it was by coincidence of some strange input method used? If yes, please let me know, whether I should fix it or whether you want to do that.

comment:2 Changed 6 years ago by trev

The ampersands indicate which letter should be the access key (see https://developer.mozilla.org/en/docs/XUL_Accesskey_FAQ_and_Policies for more information on access keys). The issue here is that we use the same string both for the menu item and tooltip.

comment:3 Changed 6 years ago by trev

  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed 6 years ago by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.