Opened 2 years ago

Closed 2 years ago

#5942 closed change (fixed)

Drop support for updateManifest generation for gecko

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, trev, fhd Blocked By:
Blocking: #5757 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29589674/

Description (last modified by tlucas)

Background

Update manifests for Firefox extensions are only necessary, if they are not hosted at AMO (see: https://developer.mozilla.org/en-US/Add-ons/Updates ). Since we started hosting both releases and developement builds at AMO, the latter became false.

What to change

Remove the code in sitescripts/extensions/bin/updateUpdateManifest.py and sitescripts/extensions/bin/createNightlies.py, as well as all related calls that attempt to create an update manifest for Adblock Plus for Firefox.

Change History (7)

comment:1 Changed 2 years ago by tlucas

I talked to Wladimir in irc about this - if we presumably don't plan to host Firefox extension builds on our own infrastructure again, this issue should be valid.

comment:2 Changed 2 years ago by tlucas

  • Description modified (diff)

comment:3 Changed 2 years ago by kvas

  • Priority changed from Unknown to P3
  • Ready set

comment:4 Changed 2 years ago by tlucas

  • Owner set to tlucas

comment:5 Changed 2 years ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5942 - don't create gecko update manifests

comment:7 Changed 2 years ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.