Opened 23 months ago

Closed 3 weeks ago

#5946 closed defect (rejected)

shouldWrapAPIs in polifills breaks ABP for Edge

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: mjethani, geo, sebastian Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29589646/

Description

Environment

ABP for Microsoft Edge

How to reproduce

  1. Build Edge extension from 66d7de4087e5.

...

Observed behaviour

When opening the options page there is an exception, which breaks the page.

Error: Invocation of form storage.local.get(array) doesn't match definition storage.local.get(optional string or array or object keys, function callback).

Expected behaviour

Options page should work.

Add a required callback parameter to storage.local.get call.

Change History (3)

comment:1 Changed 23 months ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 10 months ago by sebastian

  • Cc geo sebastian added

Is this issue still relevant? Can anyone confirm that this error no longer occurs?

comment:3 Changed 3 weeks ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from reviewing to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.