Opened 20 months ago

Last modified 6 months ago

#5946 reviewing defect

shouldWrapAPIs in polifills breaks ABP for Edge

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: mjethani, geo, sebastian Blocked By:
Blocking: Platform: Edge
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29589646/

Description

Environment

ABP for Microsoft Edge

How to reproduce

  1. Build Edge extension from 66d7de4087e5.

...

Observed behaviour

When opening the options page there is an exception, which breaks the page.

Error: Invocation of form storage.local.get(array) doesn't match definition storage.local.get(optional string or array or object keys, function callback).

Expected behaviour

Options page should work.

Add a required callback parameter to storage.local.get call.

Change History (2)

comment:1 Changed 20 months ago by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 6 months ago by sebastian

  • Cc geo sebastian added

Is this issue still relevant? Can anyone confirm that this error no longer occurs?

Note: See TracTickets for help on using tickets.