Opened 2 years ago

Closed 2 years ago

#5952 closed defect (fixed)

Clicking Cancel in the issue reporter doesn't close the tab

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: mapx Blocked By:
Blocking: #5883 Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29595588/

Description

Environment

Firefox 56, Adblock Plus 2.99.0.1898beta

How to reproduce

  1. Click ABP icon on any website
  2. Choose "Report issue on this page"
  3. Click Cancel or press Escape within the issue reporter page.

Observed behaviour

The page doesn't close. The console shows a warning:

Scripts may not close windows that were not opened by script.

Expected behaviour

The page should close, like it does in Chrome

Change History (7)

comment:1 Changed 2 years ago by mapx

same here ("block element" empty window)
https://issues.adblockplus.org/ticket/5817#comment:6

comment:2 Changed 2 years ago by mapx

  • Cc mapx added

comment:3 Changed 2 years ago by trev

  • Owner set to trev
  • Summary changed from Clicking Cancel in the issue reporter doesn't close the tag to Clicking Cancel in the issue reporter doesn't close the tab

comment:4 Changed 2 years ago by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by greiner

  • Priority changed from Unknown to P2
  • Ready set

comment:6 Changed 2 years ago by abpbot

comment:7 Changed 2 years ago by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.