Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5955 closed defect (fixed)

DNT message in Firefox targets Chrome

Reported by: arthur Assignee: saroyanm
Priority: P1 Milestone:
Module: User-Interface Keywords:
Cc: saroyanm, wspee, trev, kzar, Shikitita Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29590608/

Description (last modified by saroyanm)

Environment

Firefox Nightly 58.0a1 20171026221945
ABP 2.99.0.1900beta

How to reproduce

  1. Open ABP options
  2. Tick "Only allow Acceptable Ads that are privacy-friendly"

Observed behaviour

The following text appears: Note:

You have Do Not Track (DNT) disabled in your Chrome settings. For this feature to work properly, please enable DNT in your browser preferences. Find out how to enable DNT.

Expected behaviour

It shouldn't be targeted to the chrome browser, see -> https://bitbucket.org/adblockplus/spec/issues/98/dnt-message-targets-chrome

Change History (8)

comment:1 Changed 2 years ago by saroyanm

  • Cc trev kzar Shikitita added
  • Description modified (diff)
  • Priority changed from Unknown to P1
  • Ready set

Thanks Arthur for finding this.

comment:2 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

This is only yet translated to Spanish, Catalan and Russian, I'll update Russian translation accordingly and Tamara will take care of the Spanish and Catalan.

comment:3 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 2 years ago by saroyanm

I wonder if it would be possible to push this translation to the crowdin though.
@kzar, @trev ?

comment:7 follow-up: Changed 2 years ago by kzar

To be honest I'm not sure why you're asking me for permission to push this string to the adblockplusui Crowdin project, that's not really my call.

FWIW we're supposed to be in a string freeze already (and a feature freeze) for the Firefox release next week. But I think we're probably going to need to update the adblockplusui dependency once more before then anyway.

comment:8 in reply to: ↑ 7 Changed 2 years ago by saroyanm

Replying to kzar:
Thanks for reply.

To be honest I'm not sure why you're asking me for permission to push this string to the adblockplusui Crowdin project, that's not really my call.

Wasn't sure whom to ask while Sebastian was Out Of Office and didn't want to run it myself, as I haven't done it before and would probably need to have a permission to do that before running the script.

FWIW we're supposed to be in a string freeze already (and a feature freeze) for the Firefox release next week. But I think we're probably going to need to update the adblockplusui dependency once more before then anyway.

Yes I know, but I think this string change is important to fix before launch.
If it will not be possible to upload the string to crowdin meanwhilem I think it's better to have this in English only.

Note: See TracTickets for help on using tickets.