Opened on 10/30/2017 at 10:20:47 AM

Closed on 10/30/2017 at 10:31:29 PM

#5957 closed defect (fixed)

adblockpluschrome unit tests are broken

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.0-for-Firefox
Module: Platform Keywords:
Cc: sebastian, mjethani, trev Blocked By:
Blocking: Platform: Chrome
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)


Adblock plus for Chrome devenv built from f7eff6fa3af2.

How to reproduce

  1. Open the options page.
  2. In the developer console type location.href = "qunit/index.html";

Observed behaviour

A bunch of the tests fail with Uncaught ReferenceError: browser is not defined exceptions.

Expected behaviour

The tests pass.


Hints for testers

This doesn't need testing since it won't have any effect on the build.

Attachments (0)

Change History (5)

comment:1 Changed on 10/30/2017 at 12:21:21 PM by kzar

  • Owner set to kzar

comment:2 Changed on 10/30/2017 at 02:41:01 PM by kzar

  • Description modified (diff)

comment:3 Changed on 10/30/2017 at 02:55:30 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 10/30/2017 at 10:28:17 PM by abpbot

A commit referencing this issue has landed:
Issue 5957 - Get the unit tests passing again

comment:5 Changed on 10/30/2017 at 10:31:29 PM by kzar

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.