Opened 12 months ago

Closed 6 weeks ago

Last modified 6 weeks ago

#5960 closed change (fixed)

Fix incorrect source strings in "mobile options" project

Reported by: lisabielik Assignee: greiner
Priority: P3 Milestone:
Module: User-Interface Keywords: goodfirstbug
Cc: wspee, saroyanm, greiner, Shikitita Blocked By:
Blocking: #6936 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/106

Description

Background

There are two incorrect source strings in the mobile options project that need to be fixed.

What to change

Please enter a URL link to Please enter a URL

and

Allow some non-intrusive advertising to Allow some nonintrusive advertising

Change History (10)

comment:1 Changed 12 months ago by lisabielik

  • Cc Shikitita added

comment:2 Changed 11 months ago by trev

  • Cc greiner trev added; sebastian removed
  • Component changed from Unknown to User-Interface

I just filed a spec issue for the former (https://bitbucket.org/adblockplus/spec/issues/110/dont-use-the-bogus-term-url-link). The latter is already correct in the spec, merely not in the build. I consider the inconsistency to the desktop options page problematic however, filed https://bitbucket.org/adblockplus/spec/issues/111/inconsistent-terminology-between-desktop on it.

comment:3 Changed 10 months ago by fhd

  • Cc trev removed

comment:4 Changed 9 months ago by greiner

  • Keywords goodfirstbug added
  • Priority changed from Unknown to P3
  • Ready set

comment:5 Changed 9 months ago by lisabielik

Any reason why this still hasn't been fixed? It's been 3 months.

comment:6 Changed 9 months ago by greiner

It probably wasn't on anyone's radar and we may also have been a bit distracted by the web extension release. I went through all UI-related issues to make sure that they can be tackled so we should be back on track now.

comment:7 Changed 6 weeks ago by greiner

  • Owner set to greiner

The first string has already been fixed as part of #6659 and I've created [ui#] for the second string change.

Sorry that this has been taking so long.

comment:8 Changed 6 weeks ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 6 weeks ago by greiner

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:10 Changed 6 weeks ago by greiner

  • Blocking 6936 added
Note: See TracTickets for help on using tickets.