Changes between Initial Version and Version 5 of Ticket #5971


Ignore:
Timestamp:
11/21/2017 05:21:00 PM (2 years ago)
Author:
kzar
Comment:

(The fact you triaged this implies it belongs to User-Interface, so I've set that and copied you guys in.)

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #5971

    • Property Cc mjethani greiner saroyanm added
    • Property Component changed from Unknown to User-Interface
    • Property Summary changed from [webextension] Cannot save custom filters in Firefox 50 to [webextension] New options page is broken for Firefox 50
    • Property Priority changed from Unknown to P3
    • Property Keywords options-page added
    • Property Ready set
  • Ticket #5971 – Description

    initial v5  
    77=== How to reproduce === 
    88 1. Select [ABP Icon] > [Options]. 
    9  2. Select [Advanced] > [Create your own filter list]. 
    10  3. Attempt to add a filter. 
     9 
     10Try any of the following: 
     11 - Refreshing the page. 
     12 - Ticking one of the checkboxes. 
     13 - Whitelisting a domain. 
     14 - Adding a custom filter. 
     15 - etc. 
    1116 
    1217=== Observed behaviour === 
    13 The filter is not saved and the [Create your own filter list] button is displayed again. 
     18- After pressing refresh the options page completely breaks. 
     19- When adjusting most settings nothing appears to happen, but when the options page is next loaded the settings will show as updated. 
     20- When adjusting the "Privacy & Security" settings they are not even updated the next time the options page is loaded. 
    1421 
    1522=== Expected behaviour === 
    16 Filters to save successfully. 
     23Refreshing the options page doesn't break it. Settings are shown as updated straight after the user changes them. The "Privacy & Security" options can be updated. 
     24 
     25=== Notes === 
     26When the options page is refreshed the following message is logged: 
     27 
     28{{{ 
     29TypeError: this.cloneScope is null[Learn More] ExtensionUtils.jsm:387:1 
     30}}} 
     31 
     32When a setting is changed it appears that sending the response message back to the options page fails: 
     33 
     34{{{ 
     35Error: Could not establish connection. Receiving end does not exist. 
     36}}} 
     37 
     38When loading the options page it complains: 
     39 
     40{{{ 
     41value.indexOf is not a function desktop-options.js:1338 
     42}}}