Opened 22 months ago

Last modified 21 months ago

#5971 closed defect

[webextension] New options page is broken for Firefox 50 — at Version 6

Reported by: Ross Assignee:
Priority: P2 Milestone: Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox
Module: Platform Keywords: options-page, externaldependencies
Cc: trev, sebastian, mjethani, greiner, saroyanm Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29632555/

Description (last modified by kzar)

Environment

ABP 3.0.1
Firefox 50 / Windows 10

Works in Firefox 57.

How to reproduce

  1. Select [ABP Icon] > [Options].

Try any of the following:

  • Refreshing the page.
  • Ticking one of the checkboxes.
  • Whitelisting a domain.
  • Adding a custom filter.
  • etc.

Observed behaviour

  • After pressing refresh the options page completely breaks.
  • When adjusting most settings nothing appears to happen, but when the options page is next loaded the settings will show as updated.
  • When adjusting the "Privacy & Security" settings they are not even updated the next time the options page is loaded.

Expected behaviour

Refreshing the options page doesn't break it. Settings are shown as updated straight after the user changes them. The "Privacy & Security" options can be updated.

Notes

When the options page is refreshed the following message is logged:

TypeError: this.cloneScope is null[Learn More] ExtensionUtils.jsm:387:1

When a setting is changed it appears that sending the response message back to the options page fails:

Error: Could not establish connection. Receiving end does not exist.

When loading the options page it complains:

value.indexOf is not a function desktop-options.js:1338

Change History (6)

comment:1 Changed 22 months ago by trev

Actually, filters are being saved successfully - you can see them if you reload the page. Browser Console shows the error "Could not establish connection. Receiving end does not exist." This error might or might not be related.

comment:2 Changed 22 months ago by saroyanm

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed 22 months ago by saroyanm

  • Keywords options-page added

comment:4 Changed 22 months ago by saroyanm

The Added whitelisted domains are not being updated in the UI as well, this might be related to each other.

comment:5 Changed 21 months ago by kzar

  • Cc mjethani greiner saroyanm added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)
  • Summary changed from [webextension] Cannot save custom filters in Firefox 50 to [webextension] New options page is broken for Firefox 50

(The fact you triaged this implies it belongs to User-Interface, so I've set that and copied you guys in.)

comment:6 Changed 21 months ago by kzar

  • Description modified (diff)
Note: See TracTickets for help on using tickets.