Opened on 11/02/2017 at 01:02:45 PM

Closed on 11/23/2017 at 07:39:31 PM

Last modified on 11/30/2017 at 02:26:18 PM

#5972 closed defect (fixed)

[webextension] ABP Options page is titled "Settings"

Reported by: Ross Assignee: saroyanm
Priority: P3 Milestone:
Module: User-Interface Keywords: options-page, goodfirstbug
Cc: trev, sebastian, greiner, Shikitita, saroyanm, lisabielik, jeen, wspee Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):



Firefox 57 / Windows 10

How to reproduce

  1. Select [ABP Icon] > [Options].

Observed behaviour

The ABP Options page is titled just "Settings. This is a disconnect from the UI the user just opened it with ("Options") making it slightly confusing. In Chrome the page is titled "Adblock Plus Options".

The page is displays no favicon.

Expected behaviour

The title of the options page should probably be "Adblock Plus Options" and also display a favicon (if supported).

Attachments (0)

Change History (12)

comment:1 Changed on 11/03/2017 at 07:43:14 PM by saroyanm

  • Priority changed from Unknown to P4
  • Ready set

comment:2 Changed on 11/03/2017 at 07:44:27 PM by saroyanm

  • Keywords options-page added

comment:3 Changed on 11/14/2017 at 04:27:10 PM by kzar

  • Cc greiner Shikitita saroyanm added

This appears to be caused by a problem in adblockplusui/locale/en_US/desktop-options.json, the string "options_page_title" is listed twice:

  "options_page_title": {
    "description": "Options page title",
    "message": "Adblock Plus Options"
  "options_page_title": {
    "description": "Page title in navigation sidebar",
    "message": "Settings"

comment:4 Changed on 11/14/2017 at 04:32:45 PM by Shikitita

  • Cc lisabielik jeen wspee added

comment:5 Changed on 11/23/2017 at 02:30:16 PM by greiner

  • Keywords goodfirstbug added
  • Priority changed from P4 to P3

comment:6 Changed on 11/23/2017 at 06:10:04 PM by saroyanm

  • Owner set to saroyanm

comment:7 Changed on 11/23/2017 at 07:20:31 PM by saroyanm

  • Review URL(s) modified (diff)

comment:8 Changed on 11/23/2017 at 07:20:40 PM by saroyanm

  • Status changed from new to reviewing

comment:9 Changed on 11/23/2017 at 07:32:35 PM by abpbot

A commit referencing this issue has landed:
Issue 5972 - Fixed wrong options page title

comment:10 Changed on 11/23/2017 at 07:38:15 PM by abpbot

A commit referencing this issue has landed:
Issue 5972 - Added favicon to the options page wrapper

comment:11 Changed on 11/23/2017 at 07:39:31 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed on 11/30/2017 at 02:26:18 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set


Firefox 51 / 57 / Windows 10

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
Note: See TracTickets for help on using tickets.