Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#5973 closed defect (fixed)

[webextension] New options page icons display as blue squares in Firefox 50-52

Reported by: Ross Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: trev, sebastian, greiner, saroyanm Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29596678/

Description

Environment

ABP 2.99.0.1903beta
Firefox 50-52 / Windows 10

Works in Firefox 53+.

How to reproduce

  1. Select [ABP Icon] > [Options].
  2. Select [Advanced].

Observed behaviour

The help/? icons in the general tab and the trash icons near the filter lists display as blue squares.

Expected behaviour

Icons to display correctly.

Attachments (1)

5973-OptionsIconsOldFirefox.png (39.6 KB) - added by Ross 2 years ago.

Download all attachments as: .zip

Change History (10)

Changed 2 years ago by Ross

comment:1 Changed 2 years ago by trev

  • Cc greiner saroyanm added

The icons currently use mask CSS property which is only supported starting with Firefox 53. Unfortunately, I don't see any easy way to fix this.

comment:2 Changed 2 years ago by saroyanm

  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:4 Changed 2 years ago by saroyanm

I'm preparing patch for this one, Wladimir will you be able to review the patch ? (What is your availability?)

@Ross, what is your availability of doing tests ?
(I'll do tests before, during, after review, but will feel much more comfortable if you will be able to confirm in the end that changes works for you)

Patch should be ready around in 1 hour if I'll not notice any regression.

Version 0, edited 2 years ago by saroyanm (next)

comment:5 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:7 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 5973 - fixed broken icons on Firefox v50-53

comment:8 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Icons display correctly.

ABP 3.0.0.1911beta
Firefox 50 / 53 / Windows 10

Note: See TracTickets for help on using tickets.