Opened 3 weeks ago

Closed 2 days ago

#5977 closed defect (fixed)

[webextension] Adblock Plus menu item opens bubble UI instead of mobile options page

Reported by: Ross Assignee: mjethani
Priority: P2 Milestone: Adblock-Plus-for-Chrome-Opera-Firefox-next
Module: Platform Keywords:
Cc: trev, sebastian, kzar, greiner Blocked By: #6037
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29597555/

Description (last modified by kzar)

Environment

ABP 2.99.0.1903beta
Firefox Beta (57) / Android

How to reproduce

  1. Have ABP webextension build installed on Firefox Beta for Android.
  2. Navigate to a website (any).
  3. Select [Firefox menu] > [Adblock Plus] (bottom entry).

Observed behaviour

It opens the bubble UI meant for desktop versions.

Expected behaviour

It should open the mobile options page instead.

What to change

Modify metadata.gecko so the popup is not set in the manifest file. In lib/options.js set the popup programmatically if the platform is not Firefox for Android.

Update buildtools dependency to 1c798cc8b402 so the build script doesn't set one of the popup icons as the popup. (No other relevant changes will be included.)

Hints for testers

  • Test the popup opens correctly still for desktop browsers.
  • Test that the mobile options page opens for Firefox on Android, instead of the popup.

Change History (15)

comment:1 Changed 3 weeks ago by trev

Actually, the issue here is that the bubble is opened in the first place - it isn't meant for mobile. This is supposed to open options.

comment:2 Changed 3 weeks ago by trev

  • Description modified (diff)

comment:3 Changed 3 weeks ago by mjethani

  • Component changed from User-Interface to Platform
  • Description modified (diff)
  • Summary changed from [webextension] Issue reporter is not focused on mobile to [webextension] Adblock Plus menu item opens bubble UI instead of mobile options page

comment:4 Changed 3 weeks ago by mjethani

  • Owner set to mjethani

comment:5 Changed 3 weeks ago by mjethani

I should note here that there's a bug in Firefox for Android that prevents us from implementing an ideal fix for this issue.

comment:6 Changed 3 weeks ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 3 weeks ago by mjethani

  • Cc kzar added

comment:8 Changed 9 days ago by mjethani

  • Blocked By 6037 added

comment:9 Changed 9 days ago by kzar

  • Priority changed from Unknown to P2
  • Ready set

comment:10 Changed 7 days ago by greiner

  • Cc greiner added

comment:11 Changed 3 days ago by mjethani

  • Description modified (diff)

comment:12 Changed 2 days ago by mjethani

  • Description modified (diff)

comment:13 Changed 2 days ago by kzar

  • Description modified (diff)

comment:14 Changed 2 days ago by abpbot

A commit referencing this issue has landed:
Issue 5977 - Set popup programmatically on Firefox

comment:15 Changed 2 days ago by mjethani

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.