Opened 2 years ago

Closed 17 months ago

Last modified 12 months ago

#5987 closed change (fixed)

Remove ext.windows from adblockpluschrome

Reported by: kzar Assignee: jsonesen
Priority: P3 Milestone: Adblock-Plus-3.2-for-Chrome-Opera-Firefox
Module: Platform Keywords: goodfirstbug
Cc: sebastian, Yael Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29787568/
https://gitlab.com/eyeo/adblockplus/adblockpluschrome/merge_requests/4

Description

Background

With the changes for #5985 we removed the last use of ext.windows.create. We can now remove ext.windows from adblockpluschrome/ext/background.js.

What to change

  • Remove ext.windows from adblockpluschrome/ext/background.js

Change History (11)

comment:1 Changed 22 months ago by fhd

  • Cc trev removed

comment:2 Changed 18 months ago by kzar

  • Ready set

comment:3 Changed 17 months ago by jsonesen

  • Owner set to jsonesen

comment:4 Changed 17 months ago by jsonesen

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 17 months ago by abpbot

A commit referencing this issue has landed:
Issue 5987 - Removes ext.windows

comment:6 Changed 17 months ago by jsonesen

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 follow-up: Changed 17 months ago by kzar

Please can you add the Adblock-Plus-for-Chrome-Opera-Firefox-next milestone to this issue Jon?

comment:8 Changed 17 months ago by jsonesen

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:9 in reply to: ↑ 7 Changed 17 months ago by jsonesen

Replying to kzar:

Please can you add the Adblock-Plus-for-Chrome-Opera-Firefox-next milestone to this issue Jon?

Thanks for the reminder

comment:10 Changed 16 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Functionality such as Block element still works as expected.

ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7

comment:11 Changed 12 months ago by kzar

  • Cc Yael added
  • Review URL(s) modified (diff)

Sorry I missed your merge request Yael, but I've CC'd you and linked to it at least.

Note: See TracTickets for help on using tickets.