Opened 6 months ago

Last modified 4 months ago

#5988 new defect

[webextension] Devtools resource type dropdown doesn't work

Reported by: Ross Assignee:
Priority: P2 Milestone:
Module: Platform Keywords: externaldependencies
Cc: sebastian, mjethani, kzar, mapx, arthur Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by kzar)

Environment

ABP 2.99.0.1904
Firefox 57 / Windows 10

How to reproduce

  1. Navigate to a webpage (any).
  2. Open the browser devtools and switch to the Adblock Plus tab.
  3. Attempt to select a resource type.

Observed behaviour

Nothing happens when the resource type dropdown is clicked.

Expected behaviour

Resource type list to be generated successfully.

Notes

  • The dropdown works as expected in both Chrome and Firefox running on Linux.

Change History (15)

comment:1 Changed 6 months ago by mapx

The "Show ...items" has the same behaviour (empty or frozen)

comment:2 Changed 6 months ago by mapx

  • Cc trev mjethani kzar mapx added

comment:3 Changed 6 months ago by kzar

  • Component changed from Unknown to Platform
  • Verified working unset

comment:4 Changed 5 months ago by kzar

  • Description modified (diff)
  • Owner set to kzar
  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed 5 months ago by kzar

  • Summary changed from [webextension] Devtools resource type dropdown is empty to [webextension] Devtools resource type dropdown doesn't work

comment:6 Changed 5 months ago by kzar

  • Keywords externaldependencies added

This appears to be a Firefox bug which I don't think we'll be able to workaround. https://bugzilla.mozilla.org/show_bug.cgi?id=1417043

comment:7 Changed 5 months ago by mapx

What if ABP gives up on the devtools approach and follows uBo using a specific logger page. This way will be simpler for the medium user to access such info and other benefits (for example the famous instart logic check on the opened console ..) you are not depending anymore on all the devtools limitations.

comment:8 Changed 5 months ago by kzar

  • Owner kzar deleted

comment:9 Changed 5 months ago by arthur

  • Cc arthur added

comment:10 follow-up: Changed 5 months ago by mapx

a separate logger page would permit to keep all the requests still "alive" (in the logger) in the case of the various redirects / popunders. Now there is nothing to do when a redirect happens (the original page requests disappears and eventually get the ad-page requests). A disaster in case of debugging a page.

comment:11 follow-up: Changed 5 months ago by sebastian

That websites can detect open devtools, is a bug in Chrome which will eventually get fixed on their end. If you debug such websites as those using Instart Logic, the ABP panel alone likely isn't sufficient, and not being able to use the builtin devtools might be an even larger problem there, anyway.

The list of items being cleared on page load, is entirely unrelated. This behavior wouldn't change just by moving that log into a separate page. However, we could add a checkbox whether to clear the log on page load or not, regardless where we show it.

comment:12 in reply to: ↑ 11 Changed 5 months ago by mapx

Replying to sebastian:

The list of items being cleared on page load, is entirely unrelated. This behavior wouldn't change just by moving that log into a separate page. However, we could add a checkbox whether to clear the log on page load or not, regardless where we show it.

When I have to debug redirect crap I have to use uBo logger: guess what ? all the requests are still there (original page + redirect page). If you cannot simulate the same behaviour in the devtools, surely you can do that in a page managed by ABP.

well, ok you confirmed you can do that in the devtools too (this is a very old request I posted here on the bug tracker)
https://issues.adblockplus.org/ticket/4226

Last edited 5 months ago by mapx (previous) (diff)

comment:13 in reply to: ↑ 10 Changed 5 months ago by greiner

@mapx I've created a separate ticket for handling the deficiencies of the DevTools (see #6044).

comment:14 Changed 5 months ago by mapx

Well, interesting discovery:

Even if clicking in the boxes does nothing, you can click the box then the first letter of the item and will switch to that one.

  • first box: Type "w" => whitelisted, type "B" => blocked, type "A" => all.
  • second box: type "M" => media, type "S" => script or other and so on

Or - even better - click the box and then use the keyboard arrows (up / down) and you'll scroll all the options.

Last edited 5 months ago by mapx (previous) (diff)

comment:15 Changed 4 months ago by fhd

  • Cc trev removed
Note: See TracTickets for help on using tickets.