Opened 3 years ago

Closed 3 years ago

#5989 closed defect (fixed)

Migration crash after updating to 1.3.0

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P1 Milestone: Adblock-Browser-for-Android-1.3.1
Module: Adblock-Browser-for-Android Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):



One Plus 5
Android 7.1.1
Adblock Browser 1.3.0

How to reproduce

  1. Install Adblock Browser 1.2.0
  2. Go to the browser Settings -> General -> Home
  3. Longpress on History and select Hide
  4. Install Adblock Browser 1.3.0

Observed behaviour

The app crashes with the following error:

Process: org.adblockplus.browser, PID: 4451
java.lang.IllegalArgumentException: Expected both History and Sync panels to be present prior to Combined History.
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.combineHistoryAndSyncPanels(
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.migratePrefsFromVersionToVersion(
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.maybePerformMigration(
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.loadConfigFromString(
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.load(
    at org.mozilla.gecko.home.HomeConfig.load(
    at org.mozilla.gecko.home.HomeConfigLoader.loadInBackground(
    at org.mozilla.gecko.home.HomeConfigLoader.loadInBackground(
    at Source)
    at$LoadTask.doInBackground(Unknown Source)
    at$LoadTask.doInBackground(Unknown Source)
    at$ Source)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(
    at java.util.concurrent.ThreadPoolExecutor$

Expected behaviour

The app should open normally

Change History (5)

comment:1 Changed 3 years ago by greiner

  • Cc greiner added

comment:2 Changed 3 years ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 3 years ago by mario

  • Milestone set to Adblock-Browser-for-Android-1.3.1

comment:4 Changed 3 years ago by abpbot

A commit referencing this issue has landed:
Issue 5989 - Migration crash after updating to 1.3.0

comment:5 Changed 3 years ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.