Opened 3 weeks ago

Closed 2 weeks ago

#5989 closed defect (fixed)

Migration crash after updating to 1.3.0

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P1 Milestone: Adblock-Browser-for-Android-1.3.1
Module: Adblock-Browser-for-Android Keywords:
Cc: greiner Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29596710/

Description

Environment

One Plus 5
Android 7.1.1
Adblock Browser 1.3.0

How to reproduce

  1. Install Adblock Browser 1.2.0
  2. Go to the browser Settings -> General -> Home
  3. Longpress on History and select Hide
  4. Install Adblock Browser 1.3.0

Observed behaviour

The app crashes with the following error:

Process: org.adblockplus.browser, PID: 4451
java.lang.IllegalArgumentException: Expected both History and Sync panels to be present prior to Combined History.
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.combineHistoryAndSyncPanels(HomeConfigPrefsBackend.java:183)
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.migratePrefsFromVersionToVersion(HomeConfigPrefsBackend.java:402)
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.maybePerformMigration(HomeConfigPrefsBackend.java:471)
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.loadConfigFromString(HomeConfigPrefsBackend.java:487)
    at org.mozilla.gecko.home.HomeConfigPrefsBackend.load(HomeConfigPrefsBackend.java:523)
    at org.mozilla.gecko.home.HomeConfig.load(HomeConfig.java:1614)
    at org.mozilla.gecko.home.HomeConfigLoader.loadInBackground(HomeConfigLoader.java:27)
    at org.mozilla.gecko.home.HomeConfigLoader.loadInBackground(HomeConfigLoader.java:13)
    at android.support.v4.content.AsyncTaskLoader.onLoadInBackground(Unknown Source)
    at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(Unknown Source)
    at android.support.v4.content.AsyncTaskLoader$LoadTask.doInBackground(Unknown Source)
    at android.support.v4.content.ModernAsyncTask$2.call(Unknown Source)
    at java.util.concurrent.FutureTask.run(FutureTask.java:237)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
    at java.lang.Thread.run(Thread.java:761)

Expected behaviour

The app should open normally

Change History (5)

comment:1 Changed 3 weeks ago by greiner

  • Cc greiner added

comment:2 Changed 3 weeks ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 2 weeks ago by mario

  • Milestone set to Adblock-Browser-for-Android-1.3.1

comment:4 Changed 2 weeks ago by abpbot

A commit referencing this issue has landed:
Issue 5989 - Migration crash after updating to 1.3.0

comment:5 Changed 2 weeks ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.