Opened on 11/06/2017 at 02:41:04 PM

Closed on 11/10/2017 at 09:35:30 AM

Last modified on 11/30/2017 at 01:34:15 PM

#5997 closed defect (fixed)

Unit test files are included in the release build

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: tlucas, trev, sebastian Blocked By:
Blocking: #6022 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


adblockpluschrome b9be53e411d7

How to reproduce

  1. ./ -t chrome build
  2. unzip -d /tmp/adblockpluschrome
  3. ls /tmp/adblockpluschrome/qunit/

Observed behaviour

The qunit directory exists and it contains two files tests.js and

Expected behaviour

Neither the directory nor those files should exist.


This is a regression caused by the webpack related changes.

Integration notes

Some metadata changes will be required:

  • Remove tests.js from [general] testScripts.
  • Remove qunit/tests.js from [bundles].

Attachments (0)

Change History (6)

comment:1 Changed on 11/06/2017 at 02:46:18 PM by tlucas

  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 11/07/2017 at 03:29:35 PM by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 11/10/2017 at 09:22:47 AM by abpbot

A commit referencing this issue has landed:
Issue 5997 - Avoid including qunit files in release builds

comment:4 Changed on 11/10/2017 at 09:30:56 AM by kzar

  • Blocking 6022 added

comment:5 Changed on 11/10/2017 at 09:35:30 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 11/30/2017 at 01:34:15 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Files no longer present in builds.

adblockpluschrome / 1939:43e804dddf0e

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.