Opened 2 years ago

Closed 2 years ago

Last modified 2 months ago

#5998 closed change (duplicate)

Update "how to disable AA on Firefox" on About - Adblockplus.org

Reported by: Kai Assignee: ire
Priority: P2 Milestone:
Module: Websites Keywords: content, goodfirstbug
Cc: juliandoucette, wspee, jnink, jeen, lisabielik Blocked By: #6007
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29599601

Description (last modified by ire)

Background

After the update of ABP to 3.0 in Firefox the current text on how to disable AA here: https://adblockplus.org/en/acceptable-ads#optout
is misleading and needs to be corrected.

What to change

Change the first two bulletpoints from

**Chrome, Maxthon, Opera, Safari** - Click the Adblock Plus icon and select **Options**. Uncheck **Allow some nonintrusive advertising**.

**Firefox** - Click the Adblock Plus icon and select **Filter preferences**. Uncheck **Allow some nonintrusive advertising**.

to

**Chrome, Firefox (ABP version 3), Maxthon, Opera, Safari** - Click the Adblock Plus icon and select **Options**. Uncheck **Allow some nonintrusive advertising**.

**Firefox (ABP versions 1 and 2)** - Click the Adblock Plus icon and select **Filter preferences**. Uncheck **Allow some nonintrusive advertising**.

Change History (22)

comment:1 Changed 2 years ago by ire

  • Cc juliandoucette wspee judith_n added
  • Component changed from Unknown to Websites
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Review URL(s) modified (diff)

comment:2 Changed 2 years ago by ire

  • Cc jnink added; judith_n removed

comment:3 Changed 2 years ago by ire

  • Owner set to ire
  • Ready set

comment:4 Changed 2 years ago by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by wspee

  • Ready unset

In ABP for Firefox 3.0.0 the checkbox is not labeled Uncheck Allow some nonintrusive advertising."

comment:6 Changed 2 years ago by Kai

I think we can live with that minor error for now. Users will get to the options page at least and then its obvious what they need to uncheck. I propose we update the text again after all translations of the UI texts are live and we can come up with a global 100 % accurate solution.

What do you think?
Kai

comment:7 Changed 2 years ago by juliandoucette

  • Cc jeen lisabielik added
  • Description modified (diff)
  • Keywords content goodfirstbug added

What do you think?

I agree. But this is a product decision. What do you think Jeen/Lisa?

comment:8 Changed 2 years ago by wspee

  • Description modified (diff)

I updated the description to be "technically" accurate (although the chrome version isn't released yet but now we cannot forget it).

comment:9 Changed 2 years ago by wspee

  • Description modified (diff)

Almost

comment:10 Changed 2 years ago by wspee

  • Description modified (diff)

Changed boldness

comment:11 Changed 2 years ago by Kai

current wording fine for me.
@Jeen: Can you ACK this please?

comment:12 Changed 2 years ago by jeen

LGTM

comment:13 Changed 2 years ago by wspee

  • Ready set

comment:14 follow-up: Changed 2 years ago by lisabielik

For consistency, it should read:

Chrome, Firefox (ABP version 3), Maxthon, Opera, Safari

and

Firefox (ABP versions 1 and 2)

This is the final wording. Thanks!

comment:15 Changed 2 years ago by ire

  • Description modified (diff)

comment:16 in reply to: ↑ 14 Changed 2 years ago by ire

Replying to lisabielik:

For consistency, it should read:

Chrome, Firefox (ABP version 3), Maxthon, Opera, Safari

and

Firefox (ABP versions 1 and 2)

This is the final wording. Thanks!

Thanks Lisa. Just to be extra clear, could you have a look at the updated ticket description and let me know if that is what you want?

comment:17 follow-up: Changed 2 years ago by lisabielik

Hi Ire:

Sorry for all of the confusion. Yes, everything LGTM.

Can we wait to push this until we revert this page back to its original state? I don't know if you've been following this discussion on #websites, but we have decided to revert this page because of translations. Essentially, we want to ensure that the small changes requested in this ticket make it into the next round of translations.

Please let me know if you have any questions. Thank you! :)

comment:18 in reply to: ↑ 17 Changed 2 years ago by ire

  • Blocked By 6007 added
  • Ready unset

Replying to lisabielik:

Hi Ire:

Sorry for all of the confusion. Yes, everything LGTM.

Can we wait to push this until we revert this page back to its original state? I don't know if you've been following this discussion on #websites, but we have decided to revert this page because of translations. Essentially, we want to ensure that the small changes requested in this ticket make it into the next round of translations.

Please let me know if you have any questions. Thank you! :)

Thanks Lisa! Sure I will wait. Marking this as unready until #6007 is completed

comment:19 Changed 2 years ago by ire

  • Ready set

comment:20 Changed 2 years ago by wspee

  • Resolution set to duplicate
  • Status changed from reviewing to closed

This change will be done together with other changes via #6012 instead.

comment:21 Changed 9 months ago by tarkesh

spam

Last edited 2 months ago by kzar (previous) (diff)

comment:22 Changed 9 months ago by juliandoucette

Hello, tarkesh;

Cool question! But I'm afraid this is not an appropriate place to ask. Instead, please email support at adblockplus.org.

Note: See TracTickets for help on using tickets.