Opened 2 months ago

Last modified 3 days ago

#6008 reviewing change

Add trigger to open Updates page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar, wspee, martin, saroyanm Blocked By: #5943
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29664623/

Description (last modified by greiner)

Background

In #5943 we added a static page for outlining various changes that have been added in the latest version of Adblock Plus. Now we need to show it whenever someone updates to that particular version.

What to change

  • Update the adblockplusui dependency to include the new update page
    • #5873: Show more information on desktop options page (including a new string)
    • #5943: Added updates page (incl. new strings and images)
    • #6089: Minor modifications to an SVG file
    • #6177: Style changes for desktop options page
  • Update metadata.chrome to add a mapping for the page and required files so they're included in the build.
  • Show the update page according to the spec:

This page should open once, in a new tab, the first time the user starts the extension after he upgraded to the earliest version that contains the new options page. It should not be shown on any subsequent update.

  • Reuse suppress_first_run_page preference to not show updates page if it's set

Hints for testers

When installing the extension:

  • Show first-run page (except if suppress_first_run_page=true)
  • Don't show updates page

When updating the extension for the first time:

  • Don't show first-run page
  • Show updates page (except if suppress_first_run_page=true)

When updating the extension for the second time:

  • Don't show first-run page
  • Don't show updates page

Change History (8)

comment:1 Changed 2 months ago by greiner

  • Cc wspee martin added

comment:2 Changed 2 months ago by kzar

  • Description modified (diff)
  • Ready set

comment:3 Changed 2 months ago by greiner

  • Owner set to greiner

comment:4 Changed 2 months ago by saroyanm

  • Cc saroyanm added

comment:5 Changed 8 weeks ago by greiner

FYI: I've suggested considering the suppress_first_run_page preference when deciding whether or not to show the Updates page so please let me know if you have any objections.

comment:6 Changed 8 days ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 6 days ago by greiner

  • Description modified (diff)

Reflected previous comment in ticket description and added hints for testers.

comment:8 Changed 3 days ago by greiner

  • Description modified (diff)

Added list of UI changes included in dependency update

Note: See TracTickets for help on using tickets.