Opened 12 months ago

Closed 8 months ago

Last modified 7 months ago

#6008 closed change (duplicate)

Add trigger to open Updates page

Reported by: greiner Assignee: greiner
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar, wspee, martin, saroyanm Blocked By: #5943, #6336, #6341
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29664623/
https://codereview.adblockplus.org/29680702/

Description (last modified by greiner)

Background

In #5943 we added a static page for outlining various changes that have been added in the latest version of Adblock Plus. Now we need to show it whenever someone updates to that particular version.

What to change

  • Update the adblockplusui dependency to 2a04df826943 to include the new update page
    • #5873: Show more information on desktop options page (including a new string)
    • #5943: Added updates page (incl. new strings and images)
    • #6089: Minor modifications to an SVG file
    • #6177: Style changes for desktop options page
    • #6297/#6316: Translations for updates page
  • Update metadata.chrome to add a mapping for the page and required files so they're included in the build.
  • Show the update page according to the spec:

This page should open once, in a new tab, the first time the user starts the extension after he upgraded to the earliest version that contains the new options page. It should not be shown on any subsequent update.

  • Reuse suppress_first_run_page preference to not show updates page if it's set

Hints for testers

When installing the extension:

  • Show first-run page (except if suppress_first_run_page=true)
  • Don't show updates page

When updating the extension for the first time:

  • Don't show first-run page
  • Show updates page (except if suppress_first_run_page=true)

When updating the extension for the second time:

  • Don't show first-run page
  • Don't show updates page

Change History (15)

comment:1 Changed 12 months ago by greiner

  • Cc wspee martin added

comment:2 Changed 12 months ago by kzar

  • Description modified (diff)
  • Ready set

comment:3 Changed 11 months ago by greiner

  • Owner set to greiner

comment:4 Changed 11 months ago by saroyanm

  • Cc saroyanm added

comment:5 Changed 11 months ago by greiner

FYI: I've suggested considering the suppress_first_run_page preference when deciding whether or not to show the Updates page so please let me know if you have any objections.

comment:6 Changed 9 months ago by greiner

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 9 months ago by greiner

  • Description modified (diff)

Reflected previous comment in ticket description and added hints for testers.

comment:8 Changed 9 months ago by greiner

  • Description modified (diff)

Added list of UI changes included in dependency update

comment:9 Changed 9 months ago by greiner

  • Review URL(s) modified (diff)

comment:10 Changed 9 months ago by greiner

  • Blocked By 6336 added

comment:11 Changed 9 months ago by greiner

  • Blocked By 6341 added

comment:12 Changed 9 months ago by abpbot

A commit referencing this issue has landed:
Issue 6008 - Expose updates version via lib/prefs.js

comment:13 Changed 9 months ago by greiner

  • Description modified (diff)

Updated information for dependency update.

comment:14 Changed 8 months ago by greiner

  • Resolution set to duplicate
  • Status changed from reviewing to closed

Closing this ticket in favor of #6403 since adding the updates page trigger is no longer the only change that's required for the dependency update.

Therefore let's continue the ongoing code review over there.

comment:15 Changed 7 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Suppress first run page preference and updates page behave as described.

Chrome 65 / Ubuntu 16.04

Note: See TracTickets for help on using tickets.