Opened 16 months ago

Last modified 14 months ago

#6016 new defect

Multiple "block element" windows are permitted (chrome / firefox)

Reported by: mapx Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords:
Cc: sebastian, kzar, mjethani, jeen, athornburgh Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by mapx)

Environment

windows 7
ABP last build (1913)
chrome / firefox

How to reproduce

  • go to google.com or any other site
  • click ABP icon, click block element=> the normal window is opened (empty but this is another bug - is empty in chrome too ...)
  • click on page, refresh the page, repeat the above steps (block element and so on)

Observed behaviour

  • multiple add filter(s) windows are opened (the old one is not closed as a new block element was requested)

Expected behaviour

  • only 1 add filter(s) window should be permitted

Change History (9)

comment:1 Changed 16 months ago by mapx

  • Summary changed from Multiple "block element" are permitted (chrome / firefox) to Multiple "block element" windows are permitted (chrome / firefox)

comment:2 Changed 16 months ago by trev

At least on Linux this behavior is not reproducible, I can only open multiple "Block element" windows for different websites. Within the same website clicking the icon again indicates that blocking an element is already in progress and offers to cancel that.

comment:3 Changed 16 months ago by mapx

  • Description modified (diff)

comment:4 Changed 16 months ago by mapx

right, I added above: refresh the page => the old window will still be opened and a new one will be opened

comment:5 Changed 16 months ago by mapx

Probably it should be avoided having more "Block element" windows (even if for different websites)

comment:6 Changed 16 months ago by kzar

  • Cc jeen athornburgh added

Probably it should be avoided having more "Block element" windows (even if for different websites)

That's a question for the product team, what do you think? If you have two tabs open you could open the "block element" popup for both, is that desirable or should the first "block element" popup close when the second is opened?

comment:7 Changed 16 months ago by mapx

Well, in practice it's very difficult to have such a situation, but I see uBo is permitting working in 2 different sites, so probably "we" can permit it.

The other situation instead (2 or more windows for the same site) is clearly an issue.

comment:8 Changed 16 months ago by jeen

I would suggest only allowing one pop-up and bringing that pop-window to the front.

I would avoid having separate windows for each site because our popup window behaves very differently to uBlock - where the popup menu stays fixed to the individual pages.

comment:9 Changed 14 months ago by fhd

  • Cc trev removed
Note: See TracTickets for help on using tickets.