Opened 11 months ago

Last modified 6 months ago

#6017 new change

Update subscriptions.xml

Reported by: jwangenheim Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: mario, diegocarloslima, fhd, rjeschke, vickyyu Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

The subscriptions the user can select are parsed from subscriptions.xml file. We need to establish a process to update this file periodically.

We could:
1) Always update them manually when they change in Core
2) Include Core, and always update Core when the file changes
3) Extract it from Core at build time

I tend to go for 3)

What to change

Implement a periodic update for subscriptions.xml

Change History (5)

comment:1 Changed 11 months ago by jwangenheim

  • Cc mario diegocarloslima fhd added

comment:2 Changed 11 months ago by jwangenheim

  • Cc rjeschke added

comment:3 Changed 11 months ago by jwangenheim

  • Component changed from Adblock-Plus-for-Internet-Explorer to Adblock-Plus-for-Samsung-Browser

comment:4 Changed 11 months ago by jwangenheim

I checked the latest version of adblockpluscore:chrome/content/ui/subscriptions.xml and compared it to the version we currently use in ABP for Samsung internet. The two lists have a different structure, it looks like we use an old format in ABP for Samsung internet:

<--- Currently used in ABP for Samsung Internet --->

<subscription title="Bulgarian list (български)" homepage="http://stanev.org/abp/" type="ads" prefixes="bg">
    <variants>
      <variant title="Bulgarian list+EasyList" url="https://easylist-downloads.adblockplus.org/bulgarian_list+easylist.txt" complete="true"/>
      <variant title="Bulgarian list" url="http://stanev.org/abp/adblock_bg.txt"/>
    </variants>
</subscription>

<--- Latest version in adblockpluscore --->

<subscription title="Bulgarian list+EasyList"
                specialization="български"
                url="https://easylist-downloads.adblockplus.org/bulgarian_list+easylist.txt"
                homepage="http://stanev.org/abp/"
                prefixes="bg"
                author="Александър Станев"
                type="ads"/>

The latest version in core also only contains subscriptions of type "ads". If we would start using this list, we loose all 4 lists of type "other" (Anti-Adblocker-Blocker, Tracking, Social Media, Malware Domains).

So before we decide how to keep subscriptions.xml up to date, we need to adjust the code in ABP for Samsung Internet in order to work with the new structure.

@fhd @rene
Whats your opinion on that?

Last edited 11 months ago by jwangenheim (previous) (diff)

comment:5 Changed 6 months ago by vickyyu

  • Cc vickyyu added
Note: See TracTickets for help on using tickets.