#6021 closed change (fixed)

Refactor build.py to use modern argparse

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: trev, Sebastian Blocked By:
Blocking: #5996 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29609559/

Description (last modified by tlucas)

Background

The buildtools' build.py was implemented before a standard means of parsing command line arguments was introduced into the Python Standard Library. This has changed

What to change

  • Get rid of the custom argument parser in build.py
  • Keep all help texts and present them appropriately for every available command
  • Group commands by command, rather than by (previously) extension type

Integration Notes

The release checklist templates for Chrome/Opera/Safari and Firefox need to be adjusted to contain the new correct commands.

Other repositories must adhere to the new interface of buildtools.build:

old:

buildtools.build.processArgs(BASE_DIR, sys.argv)

new:

buildtools.build.process_args(BASE_DIR)

Hints for testers

This should have no impact on the builds themselves at all.

Change History (10)

comment:1 Changed 19 months ago by tlucas

  • Description modified (diff)

comment:2 Changed 19 months ago by tlucas

  • Cc trev Sebastian added

comment:3 Changed 19 months ago by tlucas

I decided to actually create an issue for this, since their will be some integration work.

comment:4 Changed 19 months ago by tlucas

  • Blocking 5996 added

comment:5 Changed 19 months ago by tlucas

  • Priority changed from Unknown to P3
  • Ready set

comment:6 Changed 19 months ago by tlucas

  • Owner set to tlucas

comment:7 Changed 19 months ago by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:8 Changed 19 months ago by tlucas

  • Description modified (diff)

comment:9 Changed 19 months ago by abpbot

A commit referencing this issue has landed:
Issue 6021 - Refactoring build.py

comment:10 Changed 19 months ago by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.