Opened 23 months ago

Closed 23 months ago

Last modified 22 months ago

#6022 closed defect (fixed)

Update buildtools dependency to 014321e2dfa3

Reported by: kzar Assignee: kzar
Priority: P2 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: tlucas, sebastian, trev Blocked By: #5997, #6020
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29603557/

Description (last modified by kzar)

Background

With the recent switch to webpack some files were being erroneously included in the builds. We've resolved those issues (#6020, #5997) in the buildtools and now need to update that dependency for the extension.

Included changes in buildtools

The list of changes imported by this is:


What to change

Update the buildtools dependency to:

mercurial git
014321e2dfa3 6b014d0

One unrelated change (#5994) is included, but that shouldn't matter at all.

Hints for testers

  • Check that sitekey based whitelisting still works.

Change History (5)

comment:1 Changed 23 months ago by kzar

  • Description modified (diff)

comment:2 Changed 23 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 23 months ago by abpbot

A commit referencing this issue has landed:
Issue 6022 - Update buildtools dependency to revision 014321e2dfa3

comment:4 Changed 23 months ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 22 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Child tickets appear to be working correctly.

Note: See TracTickets for help on using tickets.