Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#6031 closed change (fixed)

Implement Acceptable Ads notification

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee Blocked By: #6042
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29609587/

Description (last modified by saroyanm)

Background

In order to inform the users about the conflict of EasyPrivacy and Acceptable Ads both being enabled at the same time, we need to show the user descriptive notification.

What to change

Implement Acceptable Ads notification as specified here.

Change History (7)

comment:1 Changed 7 months ago by saroyanm

  • Description modified (diff)

comment:2 Changed 7 months ago by saroyanm

  • Owner set to saroyanm

comment:3 Changed 7 months ago by saroyanm

  • Blocked By 6042 added

comment:4 Changed 7 months ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 6031 - Implement Acceptable Ads notification

comment:6 Changed 7 months ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 7 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Works as expected.

ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Chrome 62 / Windows 7

Last edited 7 months ago by Ross (previous) (diff)
Note: See TracTickets for help on using tickets.