Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#6032 closed defect (fixed)

Page not added to the Reading List

Reported by: diegocarloslima Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Browser-for-Android-1.3.2
Module: Adblock-Browser-for-Android Keywords:
Cc: mario, tiago Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29606596/

Description (last modified by diegocarloslima)

Environment

One Plus 5
Android 7.1.1
Adblock Browser 1.3.1

On Firefox 53.0.2, there's a regression, which causes pages to not be saved in the Reading List smart folder under the BOOKMARKS tab

How to reproduce

  1. Navigate to a page, e.g. https://adblockplus.org/blog/
  2. Tap the Reader View icon in the address bar
  3. Tap the menu overflow icon and select the star to add it to the bookmarks

These steps are also described into more details here

Observed behaviour

The page is saved under the bookmarks tab, but not included in the Reading List smart folder

Expected behaviour

The page should be included in the Reading List smart folder. We might use the fix made by Mozilla to avoid future merge conflicts

Change History (7)

comment:1 Changed 6 months ago by diegocarloslima

  • Summary changed from Page not added to Reading List to Page not added to the Reading List

comment:2 Changed 6 months ago by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed 6 months ago by diegocarloslima

  • Description modified (diff)

comment:4 Changed 6 months ago by abpbot

A commit referencing this issue has landed:
Issue 6032 - Page not added to the Reading List

comment:5 Changed 6 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed 6 months ago by mario

  • Milestone set to Adblock-Browser-for-Android-1.3.2

comment:7 Changed 6 months ago by traynard

  • Verified working set
Note: See TracTickets for help on using tickets.