Opened 11 months ago

Closed 11 months ago

Last modified 11 months ago

#6035 closed defect (fixed)

[webextension] Clicking items in the devtools pane doesn't work

Reported by: kzar Assignee: kzar
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: sebastian, Ross, trev, greiner Blocked By:
Blocking: #6038 Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29607566/
https://codereview.adblockplus.org/29608555/

Description (last modified by kzar)

Environment

Firefox 57, Windows 10, adblockpluschrome 02cd0e01c0ba

How to reproduce

  1. Open the devtools for a website, switch to the Adblock Plus pane.
  2. Refresh the page.
  3. Click one of the listed resources.

Observed behaviour

Nothing happens, an exception appears in the browser console:

TypeError: ext.devtools.panels.openResource is not a function devtools-panel.js:99:9

Expected behaviour

The resource is opened / displayed. An exception does not appear in the browser console.

Hints for testers

The resource clicked should be displayed in the devtools properly where the API is supported (Chrome) but open in a new tab otherwise (Firefox).

Change History (9)

comment:1 Changed 11 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 11 months ago by kzar

  • Description modified (diff)

comment:3 Changed 11 months ago by kzar

  • Cc greiner added
  • Component changed from Platform to User-Interface
  • Priority changed from P2 to Unknown
  • Ready unset
  • Review URL(s) modified (diff)

comment:4 Changed 11 months ago by greiner

  • Priority changed from Unknown to P2
  • Ready set

comment:5 Changed 11 months ago by abpbot

A commit referencing this issue has landed:
Issue 6035 - Only use openResource API when it's supported

comment:6 Changed 11 months ago by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed 11 months ago by kzar

  • Blocking 6038 added

comment:8 Changed 11 months ago by trev

I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1417346 to improve the usability of this solution in Firefox.

comment:9 Changed 11 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. In Firefox resources are opened in a new tab, in Chrome/Opera they open in the devtools.

ABP 3.0.1.1939
Firefox 52 / 57 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7

Note: See TracTickets for help on using tickets.