Opened 7 months ago

Closed 7 months ago

Last modified 7 months ago

#6036 closed defect (fixed)

[webextension] The ABP icon by our devtools pane is blurry

Reported by: kzar Assignee: kzar
Priority: P3 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: trev, sebastian, Ross Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29608576/

Description (last modified by kzar)

Environment

Firefox 57, Windows 10, adblockpluschrome 02cd0e01c0ba

How to reproduce

  1. Open a new tab.
  2. Open the developer tools for that tab.

Observed behaviour

Our developer tools pane is listed, but the ABP icon next to "Adblock Plus" is very blurry.

Expected behaviour

The icon should appear sharp, not blurry.

Hints for testers

Open the Firefox developer tools and look at the ABP icon by our developer tools pane. On retina screens it should look sharp, on lower def screens it should look a little blurry, but make sure it doesn't look as blurry as before. (See the attached screenshot.)

Attachments (1)

6036-blury-devtools-icon.png (153.7 KB) - added by kzar 7 months ago.

Download all attachments as: .zip

Change History (6)

Changed 7 months ago by kzar

comment:1 Changed 7 months ago by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed 7 months ago by trev

For reference, I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1418299 on the API not allowing multiple icon sizes.

comment:3 Changed 7 months ago by abpbot

A commit referencing this issue has landed:
Issue 6036 - Use correct resolution for devtools pane icon

comment:4 Changed 7 months ago by kzar

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed 7 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Looks better on both retina and smaller screens.

ABP 3.0.1.1939
Firefox 51 / 57 / Windows 7
Chrome 49 / 62 / Windows 7
Opera 36 / 48 / Windows 7

Note: See TracTickets for help on using tickets.