Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6037 closed change (fixed)

Allow popup icons without popup

Reported by: mjethani Assignee: mjethani
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: kzar, sebastian Blocked By:
Blocking: #5977 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29608569/

Description

Background

For #5977 we need to set the popup dynamically in code rather than via the manifest file. But there's currently no way to specify the popup icons in buildtools without also setting the popup.

What to change

In packagerChrome.py, consider the last icon to be the popup only if the name ends in .html.

Change History (9)

comment:1 Changed 2 years ago by mjethani

  • Owner set to mjethani

comment:2 Changed 2 years ago by mjethani

  • Cc kzar sebastian added

comment:3 Changed 2 years ago by tlucas

  • Priority changed from Unknown to P2
  • Ready set

comment:4 Changed 2 years ago by mjethani

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6037 - Allow popup icons without popup

comment:6 Changed 2 years ago by mjethani

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 follow-up: Changed 2 years ago by mjethani

What should be the milestone for this one?

comment:8 in reply to: ↑ 7 ; follow-up: Changed 2 years ago by kzar

Replying to mjethani:

What should be the milestone for this one?

No, the ticket that updates the buildtools dependency for adblockpluschrome will have a milestone assigned. (That's why it's important the dependency update ticket makes it clear what needs testing.)

comment:9 in reply to: ↑ 8 Changed 2 years ago by mjethani

Replying to kzar:

Replying to mjethani:

What should be the milestone for this one?

No, the ticket that updates the buildtools dependency for adblockpluschrome will have a milestone assigned. (That's why it's important the dependency update ticket makes it clear what needs testing.)

I see, thanks.

Note: See TracTickets for help on using tickets.