Changes between Version 3 and Version 5 of Ticket #6042


Ignore:
Timestamp:
11/21/2017 01:11:37 PM (2 years ago)
Author:
kzar
Comment:

Perhaps do the dependency update to include the adblockplusui changes at the same time as a part of this issue?

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6042

    • Property Cc kzar sebastian added
    • Property Priority changed from Unknown to P3
    • Property Ready set
    • Property Owner set to saroyanm
  • Ticket #6042 – Description

    v3 v5  
    11=== Background === 
    2 In order to show tracking conflict specified in #6031 we need to introduce `ui_warn_tracking` preference. 
     2If a user has both EasyPrivacy and Acceptable Ads enable at the same time it's important we explain the inherent conflict between those lists to them (#6031). Whitelisting filters take precendence over blacklisting ones, and so the user might be subject to some tracking that way. 
     3 
     4Once the user has seen the explanation we need a way to remember not to keep displaying it again, which will be the `ui_warn_tracking` preference. 
    35 
    46=== What to change === 
    5 Add ui_warn_tracking to the [https://hg.adblockplus.org/adblockpluschrome/file/tip/lib/prefs.js preferences]: 
     7Add `ui_warn_tracking` to the [https://hg.adblockplus.org/adblockpluschrome/file/tip/lib/prefs.js preferences], make it default to true: 
    68{{{ 
    79/**