Opened 2 years ago

Last modified 2 years ago

#6042 closed change

Introduce ui_warn_tracking boolean preference — at Version 10

Reported by: saroyanm Assignee: saroyanm
Priority: P3 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: wspee, greiner, kzar, sebastian Blocked By:
Blocking: #6031 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29613772/

Description (last modified by saroyanm)

Background

If a user has both EasyPrivacy and Acceptable Ads enable at the same time it's important we explain the inherent conflict between those lists to them (#6031). Whitelisting filters take precendence over blacklisting ones, and so the user might be subject to some tracking that way.

Once the user has seen the explanation we need a way to remember not to keep displaying it, which will be the ui_warn_tracking preference.

What to change

Add ui_warn_tracking to the preferences, make it default to true:

/**
 * Whether to show tracking warning in options page when both Acceptable Ads and subscription of type "Privacy" are enabled
 * @type {boolean}
 */
defaults.ui_warn_tracking = true;

Change History (10)

comment:1 Changed 2 years ago by saroyanm

  • Blocking 6031 added

comment:2 follow-up: Changed 2 years ago by greiner

@saroyanm The JSDoc type says that this is a boolean but the default value you specify in the ticket description is a string. Based on the implementation in #6031 the default value should be changed to true.

comment:3 in reply to: ↑ 2 Changed 2 years ago by saroyanm

  • Description modified (diff)

Replying to greiner:

@saroyanm The JSDoc type says that this is a boolean but the default value you specify in the ticket description is a string. Based on the implementation in #6031 the default value should be changed to true.

Thanks for noticing, was a bad copy-past.
Fixed.

Last edited 2 years ago by saroyanm (previous) (diff)

comment:4 Changed 2 years ago by saroyanm

  • Cc kzar sebastian added

@Kzar, @Sebastian: Can you please have a look and mark this as ready if applicable.

I can also provide a patch after that.

comment:5 follow-up: Changed 2 years ago by kzar

  • Description modified (diff)
  • Owner set to saroyanm
  • Priority changed from Unknown to P3
  • Ready set

Perhaps do the dependency update to include the adblockplusui changes at the same time as a part of this issue?

comment:6 Changed 2 years ago by kzar

  • Description modified (diff)

comment:7 in reply to: ↑ 5 Changed 2 years ago by saroyanm

Replying to kzar:

Perhaps do the dependency update to include the adblockplusui changes at the same time as a part of this issue?

Okey, I think the other review should be ready soon as well.

comment:8 Changed 2 years ago by saroyanm

  • Description modified (diff)

Changed notification to warning in the description, as we reference to this as a warning currently.

comment:9 Changed 2 years ago by saroyanm

  • Description modified (diff)

I updated the description in order more properly describe the usage, as it's in general for the subscription of type="privacy" we are using/recommending.

comment:10 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.