Opened 2 years ago

Last modified 2 years ago

#6042 closed change

Introduce ui_warn_tracking boolean preference — at Version 3

Reported by: saroyanm Assignee:
Priority: P3 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: wspee, greiner, kzar, sebastian Blocked By:
Blocking: #6031 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29613772/

Description (last modified by saroyanm)

Background

In order to show tracking conflict specified in #6031 we need to introduce ui_warn_tracking preference.

What to change

Add ui_warn_tracking to the preferences:

/**
 * Whether to show tracking notification in options page when both Acceptable Ads and EasyPrivacy are enabled.
 * @type {boolean}
 */
defaults.ui_warn_tracking = true;

Change History (3)

comment:1 Changed 2 years ago by saroyanm

  • Blocking 6031 added

comment:2 follow-up: Changed 2 years ago by greiner

@saroyanm The JSDoc type says that this is a boolean but the default value you specify in the ticket description is a string. Based on the implementation in #6031 the default value should be changed to true.

comment:3 in reply to: ↑ 2 Changed 2 years ago by saroyanm

  • Description modified (diff)

Replying to greiner:

@saroyanm The JSDoc type says that this is a boolean but the default value you specify in the ticket description is a string. Based on the implementation in #6031 the default value should be changed to true.

Thanks for noticing, was a bad copy-past.
Fixed.

Last edited 2 years ago by saroyanm (previous) (diff)
Note: See TracTickets for help on using tickets.