Opened 2 years ago

Closed 3 months ago

#6044 closed change (rejected)

Add option to store request logs regardless of whether DevTools panel is open

Reported by: greiner Assignee:
Priority: Unknown Milestone:
Module: Platform Keywords: closed-in-favor-of-gitlab
Cc: mapx, kzar, sebastian, arthur, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by greiner)

Background

There have been various reports of users who want to see requests even before they open the DevTools. While we are calling the according logging functions, we don't send the data anywhere if there's no active DevTools panel.

AFAIK this is done to save memory and avoid memory leaks for the majority of users. However, we could offer an option for those who are willing to make this trade-off.

What to change

  • Introduce a preference and expose it in the options page under "Advanced"
  • If the DevTools panel is open, forward the log data to the panel
  • If the preference is false and the DevTools panel is not open, discard the log data
  • If the preference is true store the log data in memory
    • If the DevTools panel gets opened, push the stored log data to the panel
  • Discard the stored log data (either when URL changes, when domain changes or when tab is removed)

Change History (10)

comment:1 Changed 2 years ago by greiner

  • Description modified (diff)

comment:2 Changed 2 years ago by mapx

Well, sounds good.
Keeping the log data (in case of redirects etc) it's very important for debugging the various pages
see an old ticket asking this functionality:
https://issues.adblockplus.org/ticket/4226

Last edited 2 years ago by mapx (previous) (diff)

comment:3 Changed 2 years ago by kzar

  • Cc sebastian added

comment:4 Changed 2 years ago by kzar

  • Summary changed from Add option to store request logs irregardless of whether DevTools panel is open to Add option to store request logs regardless of whether DevTools panel is open

comment:5 Changed 2 years ago by arthur

  • Cc arthur added

comment:6 Changed 2 years ago by wspee

  • Cc wspee added

comment:7 Changed 2 years ago by sebastian

Well, in particular detecting element hiding hits, has a rather significant impact on the performance. And yes, the memory usage would increase too (even if we just keep track of requests). So I'm not sure if we want to provide an option to do this regardless whether the devtools panel is open. From the requests I've seen having an option to preserve the log accross page load and redirects when the devtools panel is used, as suggested in #4226, would be sufficient.

Last edited 2 years ago by sebastian (previous) (diff)

comment:8 Changed 2 years ago by mapx

It seems in the firefox devtools panel does not work the search functionality (in chrome is working fine)

comment:9 Changed 2 years ago by kzar

Yea, the API (ExtensionPanel.onSearch) has not been implemented for Firefox yet.

comment:10 Changed 3 months ago by sebastian

  • Keywords closed-in-favor-of-gitlab added
  • Resolution set to rejected
  • Status changed from new to closed

Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.

Note: See TracTickets for help on using tickets.