Opened on 11/17/2017 at 03:49:06 PM

Closed on 11/21/2017 at 12:48:40 PM

Last modified on 12/05/2017 at 10:21:58 AM

#6053 closed defect (fixed)

[webextension] Buttons in "block element" dialog do not work in Windows

Reported by: kzar Assignee: kzar
Priority: P1 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords: externaldependencies
Cc: mapx, trev, sebastian Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description (last modified by kzar)


Windows 10, Firefox 57, adblockpluschrome 35cfeacaa3f8

How to reproduce

  1. Browse to
  2. Click the ABP icon
  3. Select "Block element"
  4. Click on the Google logo image
  5. Click on the the "Add" or "Cancel" buttons

Observed behaviour

Nothing appears to happen when either button is clicked, but the following exception appears in the console:

Scripts may not close windows that were not opened by script.

Note: When the "Add" button is clicked the filter actually _is_ added, but since the window doesn't close that is not obvious to the user!

Expected behaviour

Both buttons should close the window when clicked.


  • See related discussion in #5817.
  • I can not reproduce this on Linux, only Windows.

Attachments (0)

Change History (8)

comment:1 Changed on 11/17/2017 at 03:49:34 PM by kzar

  • Description modified (diff)

comment:2 Changed on 11/17/2017 at 04:51:55 PM by kzar

  • Keywords externaldependencies added

I've opened a Firefox bug for this

comment:3 Changed on 11/20/2017 at 01:23:35 PM by trev

There is an extra allowScriptsToClose flag that can be passed to windows.create() in Firefox, added in

comment:4 Changed on 11/20/2017 at 02:15:08 PM by kzar

  • Owner set to kzar

comment:5 Changed on 11/20/2017 at 03:00:41 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:6 Changed on 11/21/2017 at 12:47:51 PM by abpbot

A commit referencing this issue has landed:
Issue 6053 - Workaround window.close problem on Firefox

comment:7 Changed on 11/21/2017 at 12:48:40 PM by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 11/30/2017 at 01:25:32 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed. Buttons on block element dialog work as expected.

(In Firefox 50/51, cancelling the dialog can leave the highlight on the page, but is probably related to #6113).

Firefox 52 / 59 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7

Last edited on 12/05/2017 at 10:21:58 AM by Ross

Add Comment

Modify Ticket

Change Properties
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Note: See TracTickets for help on using tickets.