Opened 3 years ago

Last modified 3 years ago

#6053 closed defect

[webextension] Buttons in "block element" dialog do not work in Windows — at Initial Version

Reported by: kzar Assignee:
Priority: P1 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords: externaldependencies
Cc: mapx, trev, sebastian Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29612656/

Description

Environment

Windows 10, Firefox 57, adblockpluschrome 35cfeacaa3f8

How to reproduce

  1. Browse to https://google.co.uk
  2. Click the ABP icon
  3. Select "Block element"
  4. Click on the Google logo image
  5. Click on the the "Add" or "Cancel" buttons

Observed behaviour

Nothing appears to happen when either button is clicked, but the following exception appears in the console:

Scripts may not close windows that were not opened by script.
composer.js:64:2

Note: When the "Add" button is clicked the filter actually _is_ added, but since the window doesn't close that is not obvious to the user!

Expected behaviour

Both buttons should close the window when clicked.

Notes

  • See related discussion in #5979.
  • I can not reproduce this on Linux, only Windows.

Change History (0)

Note: See TracTickets for help on using tickets.