Opened 13 months ago

Closed 11 months ago

Last modified 10 months ago

#6066 closed change (fixed)

Implement 'force update' functionality for subscriptions

Reported by: jwangenheim Assignee: jwangenheim
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.3
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: mario, tpregueiro, diegocarloslima, vickyyu Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29673565/

Description (last modified by jwangenheim)

Background

Users should be able to force update all selected lists in a easy way. Currently users need to wait for the regular update or uncheck and check a subscription in order to update it.

What to change

Implement a functionality that enables the user to update all selected subscriptions.

Change History (12)

comment:1 Changed 13 months ago by jwangenheim

  • Cc mario tpregueiro diegocarloslima added

comment:2 Changed 13 months ago by jwangenheim

  • Description modified (diff)

comment:3 Changed 13 months ago by vickyyu

  • Cc vickyyu added

comment:4 Changed 12 months ago by jwangenheim

  • Owner set to jwangenheim

comment:5 Changed 11 months ago by vickyyu

Hey Jens, what's the status here?

Some user insight: looks like some of them got issues due to filter lists not downloaded. However, it is hard for them to follow the steps to unclick and then reclick again of the filter list rather than one "force update" button.

comment:6 Changed 11 months ago by jwangenheim

Hey vicky,

no progress so far, I just started looking into it before christmas.
I think we should prioritize the open tasks soon with mario.

comment:7 Changed 11 months ago by jwangenheim

Do we even want to update the subscriptions if the user is on a metered connection? Should we use the existing setting from "Configure automatic updates" and rename it to "Configure updates"? Or should we show a dialog and ask/warn the user every time he wants to request an update? What should happen if the user clicks on "Update all subscriptions" but he is on a metered connection and only wants to update on a WIFI connection? We should probably show a Toast or something, right?

How should we go on, @vicky @mario?

Last edited 11 months ago by jwangenheim (previous) (diff)

comment:8 Changed 11 months ago by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 11 months ago by abpbot

comment:10 Changed 11 months ago by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 11 months ago by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.3

comment:12 Changed 10 months ago by rscott

  • Verified working set

LGTM. Thank you so much for implementing this; in support especially, we'll appreciate it!

Note: See TracTickets for help on using tickets.