Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6074 closed defect (fixed)

checkbox.svg is missing in the generated dev builds

Reported by: saroyanm Assignee: saroyanm
Priority: P1 Milestone: Adblock-Plus-3.0.2-for-Firefox
Module: Platform Keywords:
Cc: kzar, greiner, wspee, sebastian Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/

Description (last modified by kzar)

Environment

Firefox v56
Adblock Plus (devbuild): V3.0.1.1931

How to reproduce

  1. Open the options page

Observed behaviour

The checkboxes on the General page are missing.

Expected behaviour

The checkboxes are displayed properly.

Notes

Attachments (1)

checkboxes-missing.png (52.9 KB) - added by saroyanm 2 years ago.

Download all attachments as: .zip

Change History (11)

Changed 2 years ago by saroyanm

comment:1 Changed 2 years ago by saroyanm

  • Summary changed from Add checkbox.svg to the metadata.chrome to checkbox.svg is missing in the generated dev builds

comment:2 Changed 2 years ago by saroyanm

  • Cc greiner wspee added

I can provide patch for fixing this when this will get ready.

Forgot to include checkbox.svg in the mapping

comment:3 Changed 2 years ago by kzar

  • Cc sebastian added
  • Component changed from Unknown to Platform
  • Description modified (diff)
  • Platform changed from Unknown / Cross platform to Firefox
  • Priority changed from Unknown to P1
  • Ready set

comment:4 Changed 2 years ago by kzar

  • Description modified (diff)

comment:5 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:6 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
Issue 6074 - Added checkbox.svg to the Firefox builds

comment:8 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed 2 years ago by kzar

  • Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next

comment:10 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Checkbox is displayed as expected.

ABP 3.0.1.1939
Firefox 57 / 50 / Windows 7

Note: See TracTickets for help on using tickets.