Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#6075 closed defect (fixed)

Hide Acceptable Ads notification when corresponding subscription is removed

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, Ross, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29615620/

Description

Environment

Browser: Chrome or Firefox

How to reproduce

  1. Download adblockplusui repository and run the test server
  2. Click on Block additional tracking
  3. Observe
  4. Cick on Only allow ads without third-party tracking
  5. Observe

Observed behaviour

On step 3 a notification about Acceptable Ads is being shown, on step 5 it still persists

Expected behaviour

On step 5 no notification is shown

Change History (5)

comment:1 Changed 2 years ago by saroyanm

  • Cc wspee added
  • Owner set to saroyanm
  • Summary changed from Remove Acceptable Ads notification when corresponding subscription is removed to Hide Acceptable Ads notification when corresponding subscription is removed

comment:2 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)

comment:4 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 2 years ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Seems to work fine.

ABP 3.0.1.1939
Firefox 52 / 57 / Windows 10
Chrome 52 / 62 / Windows 7
Opera 39 / 49 / Windows 7

Note: See TracTickets for help on using tickets.