Opened 10 months ago

Closed 10 months ago

Last modified 4 months ago

#6076 closed change (fixed)

Remove old search engine ordering logic

Reported by: jwangenheim Assignee: jwangenheim
Priority: P2 Milestone: Adblock-Browser-for-Android-1.4.0
Module: Adblock-Browser-for-Android Keywords:
Cc: diegocarloslima, rjeschke, tpregueiro Blocked By:
Blocking: #6077 Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29628702/

Description (last modified by jwangenheim)

Background

The way how search engines are selected and sorted changed in Firefox 55. Due to this change we have to remove the old logic of ordering search engines for the ABB merge with Fennec 56.

What to change

Remove all the code from tranform_locales.py in mozharness for reading and writing list.txt for each locale. Mainly code in _transform_locale() and Constants

Change History (12)

comment:1 Changed 10 months ago by jwangenheim

  • Blocked By 6077 added

comment:2 Changed 10 months ago by diegocarloslima

  • Description modified (diff)

comment:3 Changed 10 months ago by diegocarloslima

  • Platform changed from Unknown / Cross platform to Adblock Browser for Android

comment:4 Changed 10 months ago by jwangenheim

  • Blocked By 6077 removed
  • Description modified (diff)

comment:5 Changed 10 months ago by jwangenheim

  • Blocking 6077 added

comment:6 Changed 10 months ago by jwangenheim

  • Description modified (diff)

comment:7 Changed 10 months ago by jwangenheim

  • Review URL(s) modified (diff)

comment:8 Changed 10 months ago by abpbot

A commit referencing this issue has landed:
Issue 6076 - Remove old search engine ordering logic

comment:9 Changed 10 months ago by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next

comment:10 Changed 10 months ago by diegocarloslima

  • Status changed from new to reviewing

comment:11 Changed 10 months ago by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:12 Changed 4 months ago by traynard

  • Verified working set

Search engine list still sorts on it's own and retains all search engines in the list as expected.

Note: See TracTickets for help on using tickets.