Opened 2 years ago

Closed 2 years ago

Last modified 22 months ago

#6089 closed defect (fixed)

SVG checkbox icon rendering issue

Reported by: saroyanm Assignee: saroyanm
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: greiner, wspee, jeen Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29659594/

Description (last modified by saroyanm)

Environment

Chrome V62
Firefox V57

How to reproduce

  1. Download ​adblockplusui repository and run the test server
  2. Open Desktop options page
  3. Observe

Observed behaviour

The SVG Icons are rendered incorrectly in comparison to Firefox V56:

  • Acceptable Ads selected checkbox, has no round border (See attachment)

Expected behaviour

Rendered SVG icons in Chrome and Firefox look similar

Attachments (4)

checkbox-default-render.png​ (4.8 KB) - added by saroyanm 2 years ago.
checkboxes-missing.png​ (52.9 KB) - added by saroyanm 2 years ago.
checkbox-selected-not-round.png​ (3.2 KB) - added by saroyanm 2 years ago.
tooltip-render-issue.png​ (3.3 KB) - added by saroyanm 2 years ago.

Download all attachments as: .zip

Change History (15)

Changed 2 years ago by saroyanm

Changed 2 years ago by saroyanm

Changed 2 years ago by saroyanm

comment:1 Changed 2 years ago by saroyanm

  • Description modified (diff)

Changed 2 years ago by saroyanm

comment:2 Changed 2 years ago by saroyanm

  • Cc greiner wspee jeen added
  • Component changed from Unknown to User-Interface
  • Description modified (diff)
  • Priority changed from Unknown to P2
  • Ready set

comment:3 Changed 2 years ago by saroyanm

I've created a reduced test case for tooltip issue and filed a Chromium bug -> ​https://bugs.chromium.org/p/chromium/issues/detail?id=789650

comment:4 Changed 2 years ago by saroyanm

  • Owner set to saroyanm

comment:5 Changed 2 years ago by saroyanm

#6115 should fix Tooltip icon has borders cut off, Acceptable Ads default checkbox, has repetitive background, depending on how fast the review will go for that issue I'll provide separate patch for this issue if needed.

comment:6 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Priority changed from P2 to P3

While the other two issues are already fixed, I'll remove them from this issue.

The other one is minor so I'll decrease the priority, I anyway have a straight forward patch ready.

comment:7 Changed 2 years ago by saroyanm

  • Description modified (diff)
  • Summary changed from SVG icons rendering issues in chrome to SVG checkbox icon rendering issue

comment:8 Changed 2 years ago by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed 2 years ago by abpbot

A commit referencing this issue has landed:
​Issue 6089 - Adjusted checkbox cut borders

comment:10 Changed 2 years ago by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:11 Changed 22 months ago by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 3.0.2.1998
Firefox 51 / 58 / Windows 10
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Note: See TracTickets for help on using tickets.