Changes between Version 18 and Version 20 of Ticket #6091


Ignore:
Timestamp:
11/24/2017 02:20:45 PM (21 months ago)
Author:
kzar
Comment:

Assuming we don't remove the feature entirely I've added a suggestion of what we could do to avoid this kind of problem happening in the future.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #6091

    • Property Component changed from Platform to User-Interface
  • Ticket #6091 – Description

    v18 v20  
    2121 - Relevant code is in adblockplusui/lib/antiadblockInit.js and string is `notification_antiadblock_message`. 
    2222 - Likely cause is [https://hg.adblockplus.org/antiadblockfilters/rev/189f8049d8d9#l1.18 this antiadblockfilters change] which added the filter `com,fr,info##div#ab-message[style^="display: block;"]`. 
     23 
     24=== What to change === 
     25Adjust the logic in the `addAntiAdblockNotification` function in adblockplusui/lib/antiadblockInit.js to avoid overly generic filters from triggering the antiadblock notification. Currently filters with a domain specified trigger the notification, but we should also check that the domain is not a TLD like ".com" nor in the publicSuffixList.